2025-01-10 11:35:44 +01:00
|
|
|
// Copyright 2010-2025 Google LLC
|
2020-05-06 18:22:10 +02:00
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
|
//
|
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
//
|
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
|
|
#include "ortools/sat/sat_inprocessing.h"
|
|
|
|
|
|
2022-02-15 18:00:11 +01:00
|
|
|
#include <algorithm>
|
|
|
|
|
#include <cmath>
|
2021-03-04 18:26:01 +01:00
|
|
|
#include <cstdint>
|
2022-02-15 18:00:11 +01:00
|
|
|
#include <deque>
|
2021-03-04 18:26:01 +01:00
|
|
|
#include <limits>
|
2024-01-12 16:31:18 +01:00
|
|
|
#include <utility>
|
2022-02-15 18:00:11 +01:00
|
|
|
#include <vector>
|
2021-03-04 18:26:01 +01:00
|
|
|
|
2025-01-19 12:04:23 +01:00
|
|
|
#include "absl/algorithm/container.h"
|
2024-01-12 16:31:18 +01:00
|
|
|
#include "absl/cleanup/cleanup.h"
|
2020-05-06 18:22:10 +02:00
|
|
|
#include "absl/container/inlined_vector.h"
|
2023-05-24 11:42:11 +02:00
|
|
|
#include "absl/log/check.h"
|
2025-03-04 21:09:32 +01:00
|
|
|
#include "absl/log/log.h"
|
2025-03-13 15:38:23 +01:00
|
|
|
#include "absl/log/vlog_is_on.h"
|
2022-02-15 18:00:11 +01:00
|
|
|
#include "absl/types/span.h"
|
|
|
|
|
#include "ortools/base/logging.h"
|
2020-05-13 11:30:15 +02:00
|
|
|
#include "ortools/base/stl_util.h"
|
2020-12-18 10:16:56 +01:00
|
|
|
#include "ortools/base/strong_vector.h"
|
2020-05-06 18:22:10 +02:00
|
|
|
#include "ortools/base/timer.h"
|
2022-02-15 18:00:11 +01:00
|
|
|
#include "ortools/sat/clause.h"
|
|
|
|
|
#include "ortools/sat/drat_checker.h"
|
2024-01-12 16:31:18 +01:00
|
|
|
#include "ortools/sat/linear_programming_constraint.h"
|
2020-05-06 18:22:10 +02:00
|
|
|
#include "ortools/sat/probing.h"
|
2022-02-15 18:00:11 +01:00
|
|
|
#include "ortools/sat/sat_base.h"
|
2020-08-26 22:14:59 +02:00
|
|
|
#include "ortools/sat/sat_decision.h"
|
2022-02-15 18:00:11 +01:00
|
|
|
#include "ortools/sat/sat_parameters.pb.h"
|
|
|
|
|
#include "ortools/sat/sat_solver.h"
|
|
|
|
|
#include "ortools/util/bitset.h"
|
|
|
|
|
#include "ortools/util/integer_pq.h"
|
2023-10-25 15:37:53 +02:00
|
|
|
#include "ortools/util/logging.h"
|
2022-02-15 18:00:11 +01:00
|
|
|
#include "ortools/util/strong_integers.h"
|
|
|
|
|
#include "ortools/util/time_limit.h"
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
namespace operations_research {
|
|
|
|
|
namespace sat {
|
|
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
void PostsolveClauses::AddClauseWithSpecialLiteral(
|
|
|
|
|
Literal literal, absl::Span<const Literal> clause) {
|
|
|
|
|
bool found = false;
|
|
|
|
|
clauses.emplace_back(clause.begin(), clause.end());
|
|
|
|
|
for (int i = 0; i < clause.size(); ++i) {
|
|
|
|
|
if (clause[i] == literal) {
|
|
|
|
|
found = true;
|
|
|
|
|
std::swap(clauses.back()[0], clauses.back()[i]);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
CHECK(found);
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
#define RETURN_IF_FALSE(f) \
|
|
|
|
|
if (!(f)) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
bool Inprocessing::PresolveLoop(SatPresolveOptions options) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
// Mainly useful for development.
|
|
|
|
|
double probing_time = 0.0;
|
2023-10-25 15:37:53 +02:00
|
|
|
const bool log_round_info = VLOG_IS_ON(1);
|
2020-05-13 11:30:15 +02:00
|
|
|
|
2020-05-06 18:22:10 +02:00
|
|
|
// We currently do the transformations in a given order and restart each time
|
2023-12-04 15:06:08 +01:00
|
|
|
// we did something to make sure that the earlier step cannot strengthen more.
|
2020-05-06 18:22:10 +02:00
|
|
|
// This might not be the best, but it is really good during development phase
|
|
|
|
|
// to make sure each individual functions is as incremental and as fast as
|
|
|
|
|
// possible.
|
|
|
|
|
const double start_dtime = time_limit_->GetElapsedDeterministicTime();
|
|
|
|
|
const double stop_dtime = start_dtime + options.deterministic_time_limit;
|
|
|
|
|
while (!time_limit_->LimitReached() &&
|
|
|
|
|
time_limit_->GetElapsedDeterministicTime() <= stop_dtime) {
|
|
|
|
|
CHECK_EQ(sat_solver_->CurrentDecisionLevel(), 0);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// This one is fast since only newly fixed variables are considered.
|
|
|
|
|
implication_graph_->RemoveFixedVariables();
|
2023-12-13 16:14:35 +01:00
|
|
|
implication_graph_->RemoveDuplicates();
|
2020-05-06 18:22:10 +02:00
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
// This also prepare the stamping below so that we do that on a DAG and do
|
|
|
|
|
// not consider potential new implications added by
|
|
|
|
|
// RemoveFixedAndEquivalentVariables().
|
2020-06-03 12:07:07 +02:00
|
|
|
RETURN_IF_FALSE(DetectEquivalencesAndStamp(options.use_transitive_reduction,
|
|
|
|
|
log_round_info));
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
// TODO(user): This should/could be integrated with the stamping since it
|
|
|
|
|
// seems better to do just one loop instead of two over all clauses. Because
|
|
|
|
|
// of memory access. it isn't that clear though.
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
2023-12-04 15:06:08 +01:00
|
|
|
|
|
|
|
|
// IMPORTANT: Since we only run this on pure sat problem, we can just
|
|
|
|
|
// get rid of equivalent variable right away and do not need to keep them
|
|
|
|
|
// in the implication_graph_ for propagation.
|
|
|
|
|
//
|
|
|
|
|
// This is needed for the correctness of the bounded variable elimination.
|
|
|
|
|
implication_graph_->RemoveAllRedundantVariables(&postsolve_->clauses);
|
|
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
RETURN_IF_FALSE(stamping_simplifier_->DoOneRound(log_round_info));
|
2020-05-06 18:22:10 +02:00
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
// We wait for the fix-point to be reached before doing the other
|
|
|
|
|
// simplifications below.
|
|
|
|
|
if (MoreFixedVariableToClean() || MoreRedundantVariableToClean() ||
|
|
|
|
|
!implication_graph_->IsDag()) {
|
2020-05-06 18:22:10 +02:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
RETURN_IF_FALSE(SubsumeAndStrenghtenRound(log_round_info));
|
|
|
|
|
if (MoreFixedVariableToClean() || MoreRedundantVariableToClean() ||
|
|
|
|
|
!implication_graph_->IsDag()) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
// TODO(user): Combine the two? this way we don't create a full literal <->
|
|
|
|
|
// clause graph twice. It might make sense to reach the BCE fix point which
|
|
|
|
|
// is unique before each variable elimination.
|
2024-07-12 13:56:11 +02:00
|
|
|
if (!params_.fill_tightened_domains_in_response()) {
|
|
|
|
|
blocked_clause_simplifier_->DoOneRound(log_round_info);
|
|
|
|
|
}
|
2023-12-04 15:06:08 +01:00
|
|
|
|
|
|
|
|
// TODO(user): this break some binary graph invariant. Fix!
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
2020-06-03 12:07:07 +02:00
|
|
|
RETURN_IF_FALSE(bounded_variable_elimination_->DoOneRound(log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(LevelZeroPropagate());
|
|
|
|
|
|
2020-05-06 18:22:10 +02:00
|
|
|
// Probing.
|
2020-05-13 11:30:15 +02:00
|
|
|
const double saved_wtime = wall_timer.Get();
|
2020-05-06 18:22:10 +02:00
|
|
|
const double time_left =
|
|
|
|
|
stop_dtime - time_limit_->GetElapsedDeterministicTime();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (time_left <= 0) break;
|
2020-05-06 18:22:10 +02:00
|
|
|
ProbingOptions probing_options;
|
|
|
|
|
probing_options.log_info = log_round_info;
|
|
|
|
|
probing_options.deterministic_limit = time_left;
|
|
|
|
|
probing_options.extract_binary_clauses =
|
|
|
|
|
options.extract_binary_clauses_in_probing;
|
|
|
|
|
RETURN_IF_FALSE(FailedLiteralProbingRound(probing_options, model_));
|
2020-05-13 11:30:15 +02:00
|
|
|
probing_time += wall_timer.Get() - saved_wtime;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
if (MoreFixedVariableToClean() || MoreRedundantVariableToClean() ||
|
|
|
|
|
!implication_graph_->IsDag()) {
|
|
|
|
|
continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
break;
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
// TODO(user): Maintain the total number of literals in the watched clauses.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
2023-10-25 15:37:53 +02:00
|
|
|
SOLVER_LOG(
|
|
|
|
|
logger_, "[Pure SAT presolve]", " num_fixed: ", trail_->Index(),
|
|
|
|
|
" num_redundant: ", implication_graph_->num_redundant_literals() / 2, "/",
|
|
|
|
|
sat_solver_->NumVariables(),
|
2025-04-02 19:07:51 +02:00
|
|
|
" num_implications: ", implication_graph_->ComputeNumImplicationsForLog(),
|
2023-10-25 15:37:53 +02:00
|
|
|
" num_watched_clauses: ", clause_manager_->num_watched_clauses(),
|
|
|
|
|
" dtime: ", time_limit_->GetElapsedDeterministicTime() - start_dtime, "/",
|
|
|
|
|
options.deterministic_time_limit, " wtime: ", wall_timer.Get(),
|
|
|
|
|
" non-probing time: ", (wall_timer.Get() - probing_time));
|
2020-06-03 12:07:07 +02:00
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool Inprocessing::InprocessingRound() {
|
2022-12-12 17:19:20 +01:00
|
|
|
DCHECK_EQ(sat_solver_->CurrentDecisionLevel(), 0);
|
2025-01-24 14:10:52 +01:00
|
|
|
if (sat_solver_->ModelIsUnsat()) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
2023-12-04 15:06:08 +01:00
|
|
|
const bool log_info = VLOG_IS_ON(1);
|
|
|
|
|
const bool log_round_info = VLOG_IS_ON(2);
|
2023-12-12 16:20:02 +01:00
|
|
|
const double start_dtime = time_limit_->GetElapsedDeterministicTime();
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Mainly useful for development.
|
|
|
|
|
double probing_time = 0.0;
|
2023-12-12 16:20:02 +01:00
|
|
|
|
|
|
|
|
// Store the dtime of the first call (first restart) and wait for the next
|
|
|
|
|
// restart.
|
|
|
|
|
if (first_inprocessing_call_) {
|
|
|
|
|
reference_dtime_ = start_dtime;
|
|
|
|
|
first_inprocessing_call_ = false;
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Try to spend a given ratio of time in the inprocessing.
|
2024-07-12 13:56:11 +02:00
|
|
|
//
|
|
|
|
|
// TODO(user): Tune the heuristic, in particular, with the current code we
|
|
|
|
|
// start some inprocessing before the first search.
|
2023-12-12 16:20:02 +01:00
|
|
|
const double diff = start_dtime - reference_dtime_;
|
|
|
|
|
if (total_dtime_ > params_.inprocessing_dtime_ratio() * diff) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2024-01-12 16:31:18 +01:00
|
|
|
// LP Propagation during inprocessing can be really slow, so we temporarily
|
|
|
|
|
// disable it.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): The LP and incremental structure will still be called though,
|
|
|
|
|
// which can take some time, try to disable it more cleanly.
|
|
|
|
|
std::vector<std::pair<LinearProgrammingConstraint*, bool>> saved_state;
|
|
|
|
|
for (LinearProgrammingConstraint* lp : *all_lp_constraints_) {
|
|
|
|
|
saved_state.push_back({lp, lp->PropagationIsEnabled()});
|
|
|
|
|
lp->EnablePropagation(false);
|
|
|
|
|
}
|
|
|
|
|
auto cleanup = absl::MakeCleanup([&saved_state]() {
|
|
|
|
|
for (const auto [lp, old_value] : saved_state) {
|
|
|
|
|
lp->EnablePropagation(old_value);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
// We make sure we do not "pollute" the current saved polarities. We will
|
|
|
|
|
// restore them at the end.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): We should probably also disable the variable/clauses activity
|
|
|
|
|
// updates.
|
2020-10-22 23:36:58 +02:00
|
|
|
decision_policy_->MaybeEnablePhaseSaving(/*save_phase=*/false);
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2023-12-13 16:14:35 +01:00
|
|
|
implication_graph_->RemoveDuplicates();
|
2020-06-03 12:07:07 +02:00
|
|
|
RETURN_IF_FALSE(DetectEquivalencesAndStamp(true, log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(LevelZeroPropagate());
|
|
|
|
|
|
|
|
|
|
// Probing.
|
2023-12-12 16:20:02 +01:00
|
|
|
if (params_.inprocessing_probing_dtime() > 0.0) {
|
|
|
|
|
const double saved_wtime = wall_timer.Get();
|
|
|
|
|
ProbingOptions probing_options;
|
|
|
|
|
probing_options.log_info = log_round_info;
|
|
|
|
|
probing_options.deterministic_limit = params_.inprocessing_probing_dtime();
|
|
|
|
|
probing_options.extract_binary_clauses = true;
|
|
|
|
|
RETURN_IF_FALSE(FailedLiteralProbingRound(probing_options, model_));
|
|
|
|
|
probing_time += wall_timer.Get() - saved_wtime;
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
RETURN_IF_FALSE(DetectEquivalencesAndStamp(true, log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(LevelZeroPropagate());
|
|
|
|
|
|
|
|
|
|
RETURN_IF_FALSE(stamping_simplifier_->DoOneRound(log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
2023-12-04 15:06:08 +01:00
|
|
|
RETURN_IF_FALSE(LevelZeroPropagate());
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// TODO(user): Add a small wrapper function to time this.
|
2023-12-04 15:06:08 +01:00
|
|
|
const auto old_counter = sat_solver_->counters();
|
2023-12-12 16:20:02 +01:00
|
|
|
if (params_.inprocessing_minimization_dtime() > 0.0) {
|
|
|
|
|
RETURN_IF_FALSE(sat_solver_->MinimizeByPropagation(
|
|
|
|
|
params_.inprocessing_minimization_dtime()));
|
|
|
|
|
}
|
2023-12-04 15:06:08 +01:00
|
|
|
const int64_t mini_num_clause =
|
|
|
|
|
sat_solver_->counters().minimization_num_clauses -
|
|
|
|
|
old_counter.minimization_num_clauses;
|
|
|
|
|
const int64_t mini_num_removed =
|
|
|
|
|
sat_solver_->counters().minimization_num_removed_literals -
|
|
|
|
|
old_counter.minimization_num_removed_literals;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2023-12-04 15:06:08 +01:00
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
2020-06-03 12:07:07 +02:00
|
|
|
RETURN_IF_FALSE(SubsumeAndStrenghtenRound(log_round_info));
|
|
|
|
|
RETURN_IF_FALSE(RemoveFixedAndEquivalentVariables(log_round_info));
|
2023-12-04 15:06:08 +01:00
|
|
|
|
|
|
|
|
// TODO(user): try to enable these? The problem is that we can only remove
|
|
|
|
|
// variables not used the non-pure SAT part of a model.
|
|
|
|
|
if (/*DISABLES_CODE*/ (false)) {
|
|
|
|
|
blocked_clause_simplifier_->DoOneRound(log_round_info);
|
|
|
|
|
RETURN_IF_FALSE(bounded_variable_elimination_->DoOneRound(log_round_info));
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
RETURN_IF_FALSE(LevelZeroPropagate());
|
|
|
|
|
|
2023-12-12 16:20:02 +01:00
|
|
|
sat_solver_->AdvanceDeterministicTime(time_limit_);
|
2020-06-03 12:07:07 +02:00
|
|
|
total_dtime_ += time_limit_->GetElapsedDeterministicTime() - start_dtime;
|
2023-12-04 15:06:08 +01:00
|
|
|
if (log_info) {
|
|
|
|
|
SOLVER_LOG(
|
|
|
|
|
logger_, "Inprocessing.", " fixed:", trail_->Index(),
|
|
|
|
|
" equiv:", implication_graph_->num_redundant_literals() / 2,
|
|
|
|
|
" bools:", sat_solver_->NumVariables(),
|
2025-04-02 19:07:51 +02:00
|
|
|
" implications:", implication_graph_->ComputeNumImplicationsForLog(),
|
2023-12-04 15:06:08 +01:00
|
|
|
" watched:", clause_manager_->num_watched_clauses(),
|
|
|
|
|
" minimization:", mini_num_clause, "|", mini_num_removed,
|
|
|
|
|
" dtime:", time_limit_->GetElapsedDeterministicTime() - start_dtime,
|
|
|
|
|
" wtime:", wall_timer.Get(),
|
|
|
|
|
" np_wtime:", (wall_timer.Get() - probing_time));
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2023-12-04 15:06:08 +01:00
|
|
|
DCHECK_EQ(sat_solver_->CurrentDecisionLevel(), 0);
|
2020-10-22 23:36:58 +02:00
|
|
|
decision_policy_->MaybeEnablePhaseSaving(/*save_phase=*/true);
|
2020-06-03 12:07:07 +02:00
|
|
|
return true;
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#undef RETURN_IF_FALSE
|
|
|
|
|
|
|
|
|
|
bool Inprocessing::MoreFixedVariableToClean() const {
|
2021-03-04 18:26:01 +01:00
|
|
|
const int64_t new_num_fixed_variables = trail_->Index();
|
2020-05-06 18:22:10 +02:00
|
|
|
return last_num_fixed_variables_ < new_num_fixed_variables;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool Inprocessing::MoreRedundantVariableToClean() const {
|
2021-03-04 18:26:01 +01:00
|
|
|
const int64_t new_num_redundant_literals =
|
2020-05-06 18:22:10 +02:00
|
|
|
implication_graph_->num_redundant_literals();
|
|
|
|
|
return last_num_redundant_literals_ < new_num_redundant_literals;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool Inprocessing::LevelZeroPropagate() {
|
|
|
|
|
CHECK_EQ(sat_solver_->CurrentDecisionLevel(), 0);
|
|
|
|
|
clause_manager_->AttachAllClauses();
|
|
|
|
|
return sat_solver_->Propagate();
|
|
|
|
|
}
|
|
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
// It make sense to do the pre-stamping right after the equivalence detection
|
|
|
|
|
// since it needs a DAG and can detect extra failed literal.
|
2020-06-03 12:07:07 +02:00
|
|
|
bool Inprocessing::DetectEquivalencesAndStamp(bool use_transitive_reduction,
|
|
|
|
|
bool log_info) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
implication_graph_->RemoveFixedVariables();
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!implication_graph_->IsDag()) {
|
|
|
|
|
// TODO(user): consider doing the transitive reduction after each SCC.
|
|
|
|
|
// It might be slow but we could try to make it more incremental to
|
|
|
|
|
// compensate and it should allow further reduction.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!implication_graph_->DetectEquivalences(log_info)) return false;
|
|
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (use_transitive_reduction) {
|
|
|
|
|
if (!implication_graph_->ComputeTransitiveReduction(log_info)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!stamping_simplifier_->ComputeStampsForNextRound(log_info)) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
return LevelZeroPropagate();
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool Inprocessing::RemoveFixedAndEquivalentVariables(bool log_info) {
|
|
|
|
|
// Preconditions.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): The level zero is required because we remove fixed variables
|
|
|
|
|
// but if we split this into two functions, we could rewrite clause at any
|
2020-05-13 11:30:15 +02:00
|
|
|
// level.
|
2020-05-06 18:22:10 +02:00
|
|
|
CHECK_EQ(sat_solver_->CurrentDecisionLevel(), 0);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Test if some work is needed.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): If only new fixed variables are there, we can use a faster
|
|
|
|
|
// function. We should also merge the code with the deletion code in
|
|
|
|
|
// sat_solver_.cc, but that require some refactoring of the dependence between
|
|
|
|
|
// files.
|
2021-03-04 18:26:01 +01:00
|
|
|
const int64_t new_num_redundant_literals =
|
2020-05-06 18:22:10 +02:00
|
|
|
implication_graph_->num_redundant_literals();
|
2021-03-04 18:26:01 +01:00
|
|
|
const int64_t new_num_fixed_variables = trail_->Index();
|
2020-05-06 18:22:10 +02:00
|
|
|
if (last_num_redundant_literals_ == new_num_redundant_literals &&
|
|
|
|
|
last_num_fixed_variables_ == new_num_fixed_variables) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
last_num_fixed_variables_ = new_num_fixed_variables;
|
|
|
|
|
last_num_redundant_literals_ = new_num_redundant_literals;
|
|
|
|
|
|
|
|
|
|
// Start the round.
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
2021-03-04 18:26:01 +01:00
|
|
|
int64_t num_removed_literals = 0;
|
|
|
|
|
int64_t num_inspected_literals = 0;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// We need this temporary vector for the DRAT proof settings, otherwise
|
|
|
|
|
// we could just have done an in-place transformation.
|
|
|
|
|
std::vector<Literal> new_clause;
|
|
|
|
|
|
|
|
|
|
// Used to mark clause literals.
|
|
|
|
|
const int num_literals(sat_solver_->NumVariables() * 2);
|
2024-07-12 13:56:11 +02:00
|
|
|
util_intops::StrongVector<LiteralIndex, bool> marked(num_literals, false);
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
clause_manager_->DeleteRemovedClauses();
|
|
|
|
|
clause_manager_->DetachAllClauses();
|
2020-10-28 13:42:36 +01:00
|
|
|
for (SatClause* clause : clause_manager_->AllClausesInCreationOrder()) {
|
2020-05-06 18:22:10 +02:00
|
|
|
bool removed = false;
|
|
|
|
|
bool need_rewrite = false;
|
|
|
|
|
|
|
|
|
|
// We first do a loop to see if there is anything to do.
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
|
|
|
|
if (assignment_.LiteralIsTrue(l)) {
|
|
|
|
|
// TODO(user): we should output literal to the proof right away,
|
|
|
|
|
// currently if we remove clauses before fixing literal the proof is
|
|
|
|
|
// wrong.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(l)) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
2020-06-11 10:01:48 +02:00
|
|
|
num_removed_literals += clause->size();
|
2020-05-06 18:22:10 +02:00
|
|
|
removed = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
if (assignment_.LiteralIsFalse(l) || implication_graph_->IsRedundant(l)) {
|
|
|
|
|
need_rewrite = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-11 10:01:48 +02:00
|
|
|
num_inspected_literals += clause->size();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (removed || !need_rewrite) continue;
|
2020-06-11 10:01:48 +02:00
|
|
|
num_inspected_literals += clause->size();
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Rewrite the clause.
|
|
|
|
|
new_clause.clear();
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
|
|
|
|
const Literal r = implication_graph_->RepresentativeOf(l);
|
2023-10-12 10:06:27 +02:00
|
|
|
if (marked[r] || assignment_.LiteralIsFalse(r)) {
|
2020-05-06 18:22:10 +02:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if (marked[r.NegatedIndex()] || assignment_.LiteralIsTrue(r)) {
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
2020-06-11 10:01:48 +02:00
|
|
|
num_removed_literals += clause->size();
|
2020-05-06 18:22:10 +02:00
|
|
|
removed = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
marked[r] = true;
|
2020-05-06 18:22:10 +02:00
|
|
|
new_clause.push_back(r);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Restore marked.
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const Literal l : new_clause) marked[l] = false;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (removed) continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
2020-06-11 10:01:48 +02:00
|
|
|
num_removed_literals += clause->size() - new_clause.size();
|
2020-05-13 11:30:15 +02:00
|
|
|
if (!clause_manager_->InprocessingRewriteClause(clause, new_clause)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): find a way to auto-tune that after a run on borg...
|
|
|
|
|
const double dtime = static_cast<double>(num_inspected_literals) * 1e-8;
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime);
|
2020-10-22 23:36:58 +02:00
|
|
|
LOG_IF(INFO, log_info) << "Cleanup. num_removed_literals: "
|
|
|
|
|
<< num_removed_literals << " dtime: " << dtime
|
|
|
|
|
<< " wtime: " << wall_timer.Get();
|
2020-05-06 18:22:10 +02:00
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): Use better work limits, see SAT09.CRAFTED.ramseycube.Q3inK12
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Be more incremental, each time a clause is added/reduced track
|
|
|
|
|
// which literal are impacted? Also try to do orthogonal reductions from one
|
|
|
|
|
// round to the next.
|
|
|
|
|
bool Inprocessing::SubsumeAndStrenghtenRound(bool log_info) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
2021-03-04 18:26:01 +01:00
|
|
|
int64_t num_subsumed_clauses = 0;
|
|
|
|
|
int64_t num_removed_literals = 0;
|
|
|
|
|
int64_t num_inspected_signatures = 0;
|
|
|
|
|
int64_t num_inspected_literals = 0;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// We need this temporary vector for the DRAT proof settings, otherwise
|
|
|
|
|
// we could just have done an in-place transformation.
|
|
|
|
|
std::vector<Literal> new_clause;
|
|
|
|
|
|
|
|
|
|
// This function needs the watcher to be detached as we might remove some
|
|
|
|
|
// of the watched literals.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): We could do that only if we do some reduction, but this is
|
|
|
|
|
// quite fast though.
|
|
|
|
|
clause_manager_->DeleteRemovedClauses();
|
|
|
|
|
clause_manager_->DetachAllClauses();
|
|
|
|
|
|
|
|
|
|
// Process clause by increasing sizes.
|
|
|
|
|
// TODO(user): probably faster without the size indirection.
|
2020-10-28 13:42:36 +01:00
|
|
|
std::vector<SatClause*> clauses =
|
2020-05-06 18:22:10 +02:00
|
|
|
clause_manager_->AllClausesInCreationOrder();
|
2023-12-04 15:06:08 +01:00
|
|
|
std::stable_sort(
|
|
|
|
|
clauses.begin(), clauses.end(),
|
|
|
|
|
[](SatClause* a, SatClause* b) { return a->size() < b->size(); });
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Used to mark clause literals.
|
|
|
|
|
const LiteralIndex num_literals(sat_solver_->NumVariables() * 2);
|
|
|
|
|
SparseBitset<LiteralIndex> marked(num_literals);
|
|
|
|
|
|
|
|
|
|
// Clause index in clauses.
|
|
|
|
|
// TODO(user): Storing signatures here might be faster?
|
2024-07-12 13:56:11 +02:00
|
|
|
util_intops::StrongVector<LiteralIndex, absl::InlinedVector<int, 6>>
|
|
|
|
|
one_watcher(num_literals.value());
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Clause signatures in the same order as clauses.
|
2021-03-04 18:26:01 +01:00
|
|
|
std::vector<uint64_t> signatures(clauses.size());
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
std::vector<Literal> candidates_for_removal;
|
|
|
|
|
for (int clause_index = 0; clause_index < clauses.size(); ++clause_index) {
|
2020-10-28 13:42:36 +01:00
|
|
|
SatClause* clause = clauses[clause_index];
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// TODO(user): Better abort limit. We could also limit the watcher sizes and
|
|
|
|
|
// never look at really long clauses. Note that for an easier
|
|
|
|
|
// incrementality, it is better to reach some kind of completion so we know
|
|
|
|
|
// what new stuff need to be done.
|
|
|
|
|
if (num_inspected_literals + num_inspected_signatures > 1e9) {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
// Check for subsumption, note that this currently ignore all clauses in the
|
|
|
|
|
// binary implication graphs. Stamping is doing some of that (and some also
|
|
|
|
|
// happen during probing), but we could consider only direct implications
|
|
|
|
|
// here and be a bit more exhaustive than what stamping do with them (at
|
|
|
|
|
// least for node with many incoming and outgoing implications).
|
2020-05-06 18:22:10 +02:00
|
|
|
//
|
|
|
|
|
// TODO(user): Do some reduction using binary clauses. Note that only clause
|
|
|
|
|
// that never propagated since last round need to be checked for binary
|
2020-05-13 11:30:15 +02:00
|
|
|
// subsumption.
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Compute hash and mark literals.
|
2021-03-04 18:26:01 +01:00
|
|
|
uint64_t signature = 0;
|
2025-03-07 10:33:36 +01:00
|
|
|
marked.ResetAllToFalse();
|
2020-05-06 18:22:10 +02:00
|
|
|
for (const Literal l : clause->AsSpan()) {
|
|
|
|
|
marked.Set(l.Index());
|
2021-03-04 18:26:01 +01:00
|
|
|
signature |= (uint64_t{1} << (l.Variable().value() % 64));
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Look for clause that subsumes this one. Note that because we inspect
|
|
|
|
|
// all one watcher lists for the literals of this clause, if a clause is
|
|
|
|
|
// included inside this one, it must appear in one of these lists.
|
|
|
|
|
bool removed = false;
|
|
|
|
|
candidates_for_removal.clear();
|
2021-03-04 18:26:01 +01:00
|
|
|
const uint64_t mask = ~signature;
|
2020-05-06 18:22:10 +02:00
|
|
|
for (const Literal l : clause->AsSpan()) {
|
2023-10-12 10:06:27 +02:00
|
|
|
num_inspected_signatures += one_watcher[l].size();
|
|
|
|
|
for (const int i : one_watcher[l]) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if ((mask & signatures[i]) != 0) continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
bool subsumed = true;
|
|
|
|
|
bool stengthen = true;
|
|
|
|
|
LiteralIndex to_remove = kNoLiteralIndex;
|
2020-06-11 10:01:48 +02:00
|
|
|
num_inspected_literals += clauses[i]->size();
|
2020-05-06 18:22:10 +02:00
|
|
|
for (const Literal o : clauses[i]->AsSpan()) {
|
2023-10-12 10:06:27 +02:00
|
|
|
if (!marked[o]) {
|
2020-05-06 18:22:10 +02:00
|
|
|
subsumed = false;
|
|
|
|
|
if (to_remove == kNoLiteralIndex && marked[o.NegatedIndex()]) {
|
|
|
|
|
to_remove = o.NegatedIndex();
|
|
|
|
|
} else {
|
|
|
|
|
stengthen = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (subsumed) {
|
|
|
|
|
++num_subsumed_clauses;
|
2020-06-11 10:01:48 +02:00
|
|
|
num_removed_literals += clause->size();
|
2020-05-13 11:30:15 +02:00
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
2020-05-06 18:22:10 +02:00
|
|
|
removed = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
if (stengthen) {
|
|
|
|
|
CHECK_NE(kNoLiteralIndex, to_remove);
|
|
|
|
|
candidates_for_removal.push_back(Literal(to_remove));
|
|
|
|
|
}
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (removed) break;
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (removed) continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// For strengthenning we also need to check the negative watcher lists.
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
|
|
|
|
num_inspected_signatures += one_watcher[l.NegatedIndex()].size();
|
|
|
|
|
for (const int i : one_watcher[l.NegatedIndex()]) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if ((mask & signatures[i]) != 0) continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
bool stengthen = true;
|
2020-06-11 10:01:48 +02:00
|
|
|
num_inspected_literals += clauses[i]->size();
|
2020-05-06 18:22:10 +02:00
|
|
|
for (const Literal o : clauses[i]->AsSpan()) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (o == l.Negated()) continue;
|
2023-10-12 10:06:27 +02:00
|
|
|
if (!marked[o]) {
|
2020-05-06 18:22:10 +02:00
|
|
|
stengthen = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (stengthen) {
|
|
|
|
|
candidates_for_removal.push_back(l);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Any literal here can be removed, but afterwards the other might not. For
|
|
|
|
|
// now we just remove the first one.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): remove first and see if other still removable. Alternatively
|
|
|
|
|
// use a "removed" marker and redo a check for each clause that simplifies
|
|
|
|
|
// this one? Or just remove the first one, and wait for next round.
|
|
|
|
|
if (!candidates_for_removal.empty()) {
|
|
|
|
|
new_clause.clear();
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (l == candidates_for_removal[0]) continue;
|
2023-12-04 15:06:08 +01:00
|
|
|
new_clause.push_back(l);
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
2023-12-04 15:06:08 +01:00
|
|
|
CHECK_EQ(new_clause.size() + 1, clause->size());
|
2020-05-06 18:22:10 +02:00
|
|
|
|
2020-06-11 10:01:48 +02:00
|
|
|
num_removed_literals += clause->size() - new_clause.size();
|
2020-05-13 11:30:15 +02:00
|
|
|
if (!clause_manager_->InprocessingRewriteClause(clause, new_clause)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clause->size() == 0) continue;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// Recompute signature.
|
|
|
|
|
signature = 0;
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
2021-03-04 18:26:01 +01:00
|
|
|
signature |= (uint64_t{1} << (l.Variable().value() % 64));
|
2020-05-06 18:22:10 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Register one literal to watch. Any literal works, but we choose the
|
|
|
|
|
// smallest list.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): No need to add this clause if we know it cannot subsume
|
|
|
|
|
// any new clause since last round. i.e. unchanged clause that do not
|
|
|
|
|
// contains any literals of newly added clause do not need to be added
|
|
|
|
|
// here. We can track two bitset in LiteralWatchers via a register
|
|
|
|
|
// mechanism:
|
|
|
|
|
// - literal of newly watched clauses since last clear.
|
|
|
|
|
// - literal of reduced clauses since last clear.
|
|
|
|
|
//
|
|
|
|
|
// Important: we can only use this clause to subsume/strenghten others if
|
|
|
|
|
// it cannot be deleted later.
|
|
|
|
|
if (!clause_manager_->IsRemovable(clause)) {
|
2021-03-04 18:26:01 +01:00
|
|
|
int min_size = std::numeric_limits<int32_t>::max();
|
2020-05-06 18:22:10 +02:00
|
|
|
LiteralIndex min_literal = kNoLiteralIndex;
|
|
|
|
|
for (const Literal l : clause->AsSpan()) {
|
2023-10-12 10:06:27 +02:00
|
|
|
if (one_watcher[l].size() < min_size) {
|
|
|
|
|
min_size = one_watcher[l].size();
|
2020-05-06 18:22:10 +02:00
|
|
|
min_literal = l.Index();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): We could/should sort the literal in this clause by
|
|
|
|
|
// using literals that appear in a small number of clauses first so that
|
|
|
|
|
// we maximize the chance of early abort in the critical loops above.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): We could also move the watched literal first so we always
|
|
|
|
|
// skip it.
|
|
|
|
|
signatures[clause_index] = signature;
|
|
|
|
|
one_watcher[min_literal].push_back(clause_index);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// We might have fixed variables, finish the propagation.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!LevelZeroPropagate()) return false;
|
2020-05-06 18:22:10 +02:00
|
|
|
|
|
|
|
|
// TODO(user): tune the deterministic time.
|
|
|
|
|
const double dtime = static_cast<double>(num_inspected_signatures) * 1e-8 +
|
|
|
|
|
static_cast<double>(num_inspected_literals) * 5e-9;
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime);
|
2020-10-22 23:36:58 +02:00
|
|
|
LOG_IF(INFO, log_info) << "Subsume. num_removed_literals: "
|
|
|
|
|
<< num_removed_literals
|
|
|
|
|
<< " num_subsumed: " << num_subsumed_clauses
|
|
|
|
|
<< " dtime: " << dtime
|
|
|
|
|
<< " wtime: " << wall_timer.Get();
|
2020-05-06 18:22:10 +02:00
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2020-05-13 11:30:15 +02:00
|
|
|
bool StampingSimplifier::DoOneRound(bool log_info) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
|
|
|
|
dtime_ = 0.0;
|
|
|
|
|
num_subsumed_clauses_ = 0;
|
|
|
|
|
num_removed_literals_ = 0;
|
|
|
|
|
num_fixed_ = 0;
|
|
|
|
|
|
2025-04-02 19:07:51 +02:00
|
|
|
if (implication_graph_->IsEmpty()) return true;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
if (!stamps_are_already_computed_) {
|
|
|
|
|
// We need a DAG so that we don't have cycle while we sample the tree.
|
|
|
|
|
// TODO(user): We could probably deal with it if needed so that we don't
|
2022-04-06 17:33:00 +02:00
|
|
|
// need to do equivalence detection each time we want to run this.
|
2020-05-13 11:30:15 +02:00
|
|
|
implication_graph_->RemoveFixedVariables();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!implication_graph_->DetectEquivalences(log_info)) return true;
|
2020-05-13 11:30:15 +02:00
|
|
|
SampleTreeAndFillParent();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!ComputeStamps()) return false;
|
2020-05-13 11:30:15 +02:00
|
|
|
}
|
|
|
|
|
stamps_are_already_computed_ = false;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!ProcessClauses()) return false;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
// Note that num_removed_literals_ do not count the literals of the subsumed
|
|
|
|
|
// clauses.
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime_);
|
2020-10-22 23:36:58 +02:00
|
|
|
LOG_IF(INFO, log_info) << "Stamping. num_removed_literals: "
|
|
|
|
|
<< num_removed_literals_
|
|
|
|
|
<< " num_subsumed: " << num_subsumed_clauses_
|
|
|
|
|
<< " num_fixed: " << num_fixed_ << " dtime: " << dtime_
|
|
|
|
|
<< " wtime: " << wall_timer.Get();
|
2020-05-13 11:30:15 +02:00
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool StampingSimplifier::ComputeStampsForNextRound(bool log_info) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
dtime_ = 0.0;
|
|
|
|
|
num_fixed_ = 0;
|
|
|
|
|
|
2025-04-02 19:07:51 +02:00
|
|
|
if (implication_graph_->IsEmpty()) return true;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
implication_graph_->RemoveFixedVariables();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!implication_graph_->DetectEquivalences(log_info)) return true;
|
2020-05-13 11:30:15 +02:00
|
|
|
SampleTreeAndFillParent();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!ComputeStamps()) return false;
|
2020-05-13 11:30:15 +02:00
|
|
|
stamps_are_already_computed_ = true;
|
|
|
|
|
|
|
|
|
|
// TODO(user): compute some dtime, it is always zero currently.
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime_);
|
2024-10-07 11:08:38 +02:00
|
|
|
LOG_IF(INFO, log_info) << "Prestamping."
|
|
|
|
|
<< " num_fixed: " << num_fixed_ << " dtime: " << dtime_
|
2020-05-13 11:30:15 +02:00
|
|
|
<< " wtime: " << wall_timer.Get();
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void StampingSimplifier::SampleTreeAndFillParent() {
|
|
|
|
|
const int size = implication_graph_->literal_size();
|
2020-10-22 23:36:58 +02:00
|
|
|
CHECK(implication_graph_->IsDag()); // so we don't have cycle.
|
2020-05-13 11:30:15 +02:00
|
|
|
parents_.resize(size);
|
|
|
|
|
for (LiteralIndex i(0); i < size; ++i) {
|
2020-10-22 23:36:58 +02:00
|
|
|
parents_[i] = i; // default.
|
|
|
|
|
if (implication_graph_->IsRedundant(Literal(i))) continue;
|
|
|
|
|
if (assignment_.LiteralIsAssigned(Literal(i))) continue;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
// TODO(user): Better algo to not select redundant parent.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): if parents_[x] = y, try not to have parents_[not(y)] = not(x)
|
|
|
|
|
// because this is not as useful for the simplification power.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): More generally, we could sample a parent while probing so
|
|
|
|
|
// that we consider all hyper binary implications (in the case we don't add
|
|
|
|
|
// them to the implication graph already).
|
|
|
|
|
for (int num_tries = 0; num_tries < 10; ++num_tries) {
|
2024-03-04 18:07:17 +01:00
|
|
|
// We look for a random lit that implies i. For that we take a random
|
|
|
|
|
// literal in the direct implications of not(i) and reverse it.
|
|
|
|
|
const LiteralIndex index =
|
|
|
|
|
implication_graph_->RandomImpliedLiteral(Literal(i).Negated());
|
|
|
|
|
if (index == kNoLiteralIndex) break;
|
|
|
|
|
|
|
|
|
|
const Literal candidate = Literal(index).Negated();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (implication_graph_->IsRedundant(candidate)) continue;
|
|
|
|
|
if (i == candidate.Index()) continue;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
// We found an interesting parent.
|
|
|
|
|
parents_[i] = candidate.Index();
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool StampingSimplifier::ComputeStamps() {
|
|
|
|
|
const int size = implication_graph_->literal_size();
|
|
|
|
|
|
|
|
|
|
// Compute sizes.
|
|
|
|
|
sizes_.assign(size, 0);
|
|
|
|
|
for (LiteralIndex i(0); i < size; ++i) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (parents_[i] == i) continue; // leaf.
|
2020-05-13 11:30:15 +02:00
|
|
|
sizes_[parents_[i]]++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Compute starts in the children_ vector for each node.
|
2020-10-22 23:36:58 +02:00
|
|
|
starts_.resize(size + 1); // We use a sentinel.
|
2020-05-13 11:30:15 +02:00
|
|
|
starts_[LiteralIndex(0)] = 0;
|
|
|
|
|
for (LiteralIndex i(1); i <= size; ++i) {
|
|
|
|
|
starts_[i] = starts_[i - 1] + sizes_[i - 1];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Fill children. This messes up starts_.
|
|
|
|
|
children_.resize(size);
|
|
|
|
|
for (LiteralIndex i(0); i < size; ++i) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (parents_[i] == i) continue; // leaf.
|
2020-05-13 11:30:15 +02:00
|
|
|
children_[starts_[parents_[i]]++] = i;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Reset starts to correct value.
|
|
|
|
|
for (LiteralIndex i(0); i < size; ++i) {
|
|
|
|
|
starts_[i] -= sizes_[i];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (DEBUG_MODE) {
|
|
|
|
|
CHECK_EQ(starts_[LiteralIndex(0)], 0);
|
|
|
|
|
for (LiteralIndex i(1); i <= size; ++i) {
|
|
|
|
|
CHECK_EQ(starts_[i], starts_[i - 1] + sizes_[i - 1]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Perform a DFS from each root to compute the stamps.
|
2021-03-04 18:26:01 +01:00
|
|
|
int64_t stamp = 0;
|
2020-05-13 11:30:15 +02:00
|
|
|
first_stamps_.resize(size);
|
|
|
|
|
last_stamps_.resize(size);
|
|
|
|
|
marked_.assign(size, false);
|
|
|
|
|
for (LiteralIndex i(0); i < size; ++i) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (parents_[i] != i) continue; // Not a root.
|
2020-05-13 11:30:15 +02:00
|
|
|
DCHECK(!marked_[i]);
|
|
|
|
|
const LiteralIndex tree_root = i;
|
|
|
|
|
dfs_stack_.push_back(i);
|
|
|
|
|
while (!dfs_stack_.empty()) {
|
|
|
|
|
const LiteralIndex top = dfs_stack_.back();
|
|
|
|
|
if (marked_[top]) {
|
|
|
|
|
dfs_stack_.pop_back();
|
|
|
|
|
last_stamps_[top] = stamp++;
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
first_stamps_[top] = stamp++;
|
|
|
|
|
marked_[top] = true;
|
|
|
|
|
|
|
|
|
|
// Failed literal detection. If the negation of top is in the same
|
|
|
|
|
// tree, we can fix the LCA of top and its negation to false.
|
|
|
|
|
if (marked_[Literal(top).NegatedIndex()] &&
|
|
|
|
|
first_stamps_[Literal(top).NegatedIndex()] >=
|
|
|
|
|
first_stamps_[tree_root]) {
|
|
|
|
|
// Find the LCA.
|
|
|
|
|
const int first_stamp = first_stamps_[Literal(top).NegatedIndex()];
|
|
|
|
|
LiteralIndex lca = top;
|
|
|
|
|
while (first_stamps_[lca] > first_stamp) {
|
|
|
|
|
lca = parents_[lca];
|
|
|
|
|
}
|
|
|
|
|
++num_fixed_;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(Literal(lca).Negated())) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
const int end = starts_[top + 1]; // Ok with sentinel.
|
2020-05-13 11:30:15 +02:00
|
|
|
for (int j = starts_[top]; j < end; ++j) {
|
2020-10-22 23:36:58 +02:00
|
|
|
DCHECK_NE(top, children_[j]); // We removed leaf self-loop.
|
|
|
|
|
DCHECK(!marked_[children_[j]]); // This is a tree.
|
2020-05-13 11:30:15 +02:00
|
|
|
dfs_stack_.push_back(children_[j]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
DCHECK_EQ(stamp, 2 * size);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool StampingSimplifier::ProcessClauses() {
|
|
|
|
|
struct Entry {
|
2020-10-22 23:36:58 +02:00
|
|
|
int i; // Index in the clause.
|
|
|
|
|
bool is_negated; // Correspond to clause[i] or clause[i].Negated();
|
|
|
|
|
int start; // Note that all start stamps are different.
|
2020-05-13 11:30:15 +02:00
|
|
|
int end;
|
2020-10-28 13:42:36 +01:00
|
|
|
bool operator<(const Entry& o) const { return start < o.start; }
|
2020-05-13 11:30:15 +02:00
|
|
|
};
|
|
|
|
|
std::vector<int> to_remove;
|
|
|
|
|
std::vector<Literal> new_clause;
|
|
|
|
|
std::vector<Entry> entries;
|
|
|
|
|
clause_manager_->DeleteRemovedClauses();
|
|
|
|
|
clause_manager_->DetachAllClauses();
|
2020-10-28 13:42:36 +01:00
|
|
|
for (SatClause* clause : clause_manager_->AllClausesInCreationOrder()) {
|
2020-05-13 11:30:15 +02:00
|
|
|
const auto span = clause->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (span.empty()) continue;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
// Note that we might fix literal as we perform the loop here, so we do
|
|
|
|
|
// need to deal with them.
|
|
|
|
|
//
|
2020-05-13 11:30:15 +02:00
|
|
|
// For a and b in the clause, if not(a) => b is present, then the clause is
|
|
|
|
|
// subsumed. If a => b, then a can be removed, and if not(a) => not(b) then
|
|
|
|
|
// b can be removed. Nothing can be done if a => not(b).
|
|
|
|
|
entries.clear();
|
|
|
|
|
for (int i = 0; i < span.size(); ++i) {
|
2020-06-03 12:07:07 +02:00
|
|
|
if (assignment_.LiteralIsTrue(span[i])) {
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
|
|
|
|
break;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.LiteralIsFalse(span[i])) continue;
|
2023-10-12 10:06:27 +02:00
|
|
|
entries.push_back(
|
|
|
|
|
{i, false, first_stamps_[span[i]], last_stamps_[span[i]]});
|
2020-10-22 23:36:58 +02:00
|
|
|
entries.push_back({i, true, first_stamps_[span[i].NegatedIndex()],
|
|
|
|
|
last_stamps_[span[i].NegatedIndex()]});
|
2020-05-13 11:30:15 +02:00
|
|
|
}
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clause->IsRemoved()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// The sort should be dominant.
|
|
|
|
|
if (!entries.empty()) {
|
|
|
|
|
const double n = static_cast<double>(entries.size());
|
|
|
|
|
dtime_ += 1.5e-8 * n * std::log(n);
|
|
|
|
|
std::sort(entries.begin(), entries.end());
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
Entry top_entry;
|
2020-10-22 23:36:58 +02:00
|
|
|
top_entry.end = -1; // Sentinel.
|
2020-05-13 11:30:15 +02:00
|
|
|
to_remove.clear();
|
2020-10-28 13:42:36 +01:00
|
|
|
for (const Entry& e : entries) {
|
2020-05-13 11:30:15 +02:00
|
|
|
if (e.end < top_entry.end) {
|
|
|
|
|
// We found an implication: top_entry => this entry.
|
|
|
|
|
const Literal lhs = top_entry.is_negated ? span[top_entry.i].Negated()
|
|
|
|
|
: span[top_entry.i];
|
|
|
|
|
const Literal rhs = e.is_negated ? span[e.i].Negated() : span[e.i];
|
|
|
|
|
DCHECK(ImplicationIsInTree(lhs, rhs));
|
|
|
|
|
|
|
|
|
|
if (top_entry.is_negated != e.is_negated) {
|
|
|
|
|
// Failed literal?
|
|
|
|
|
if (top_entry.i == e.i) {
|
|
|
|
|
++num_fixed_;
|
|
|
|
|
if (top_entry.is_negated) {
|
|
|
|
|
// not(span[i]) => span[i] so span[i] true.
|
|
|
|
|
// And the clause is satisfied (so we count as as subsumed).
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(span[top_entry.i])) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
} else {
|
|
|
|
|
// span[i] => not(span[i]) so span[i] false.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(
|
|
|
|
|
span[top_entry.i].Negated())) {
|
2020-06-03 12:07:07 +02:00
|
|
|
return false;
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
to_remove.push_back(top_entry.i);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// not(a) => b : subsumption.
|
|
|
|
|
// a => not(b), we cannot deduce anything, but it might make sense
|
|
|
|
|
// to see if not(b) implies anything instead of just keeping
|
|
|
|
|
// top_entry. See TODO below.
|
|
|
|
|
if (top_entry.is_negated) {
|
|
|
|
|
num_subsumed_clauses_++;
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
CHECK_NE(top_entry.i, e.i);
|
|
|
|
|
if (top_entry.is_negated) {
|
|
|
|
|
// not(a) => not(b), we can remove b.
|
|
|
|
|
to_remove.push_back(e.i);
|
|
|
|
|
} else {
|
|
|
|
|
// a => b, we can remove a.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Note that it is okay to still use top_entry, but we
|
|
|
|
|
// might miss the removal of b if b => c. Also the paper do things
|
|
|
|
|
// differently. Make sure we don't miss any simplification
|
|
|
|
|
// opportunites by not changing top_entry. Same in the other
|
|
|
|
|
// branches.
|
|
|
|
|
to_remove.push_back(top_entry.i);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
top_entry = e;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clause->IsRemoved()) continue;
|
2020-05-13 11:30:15 +02:00
|
|
|
|
|
|
|
|
// Strengthen the clause.
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!to_remove.empty() || entries.size() < span.size()) {
|
2020-05-13 11:30:15 +02:00
|
|
|
new_clause.clear();
|
|
|
|
|
gtl::STLSortAndRemoveDuplicates(&to_remove);
|
|
|
|
|
int to_remove_index = 0;
|
|
|
|
|
for (int i = 0; i < span.size(); ++i) {
|
|
|
|
|
if (to_remove_index < to_remove.size() &&
|
|
|
|
|
i == to_remove[to_remove_index]) {
|
|
|
|
|
++to_remove_index;
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
if (assignment_.LiteralIsTrue(span[i])) {
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clause);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.LiteralIsFalse(span[i])) continue;
|
2020-05-13 11:30:15 +02:00
|
|
|
new_clause.push_back(span[i]);
|
|
|
|
|
}
|
|
|
|
|
num_removed_literals_ += span.size() - new_clause.size();
|
|
|
|
|
if (!clause_manager_->InprocessingRewriteClause(clause, new_clause)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
void BlockedClauseSimplifier::DoOneRound(bool log_info) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
|
|
|
|
dtime_ = 0.0;
|
|
|
|
|
num_blocked_clauses_ = 0;
|
|
|
|
|
num_inspected_literals_ = 0;
|
|
|
|
|
|
|
|
|
|
InitializeForNewRound();
|
|
|
|
|
|
|
|
|
|
while (!time_limit_->LimitReached() && !queue_.empty()) {
|
|
|
|
|
const Literal l = queue_.front();
|
2023-10-12 10:06:27 +02:00
|
|
|
in_queue_[l] = false;
|
2020-06-03 12:07:07 +02:00
|
|
|
queue_.pop_front();
|
2023-12-04 15:06:08 +01:00
|
|
|
|
|
|
|
|
// Avoid doing too much work here on large problem.
|
|
|
|
|
// Note that we still what to empty the queue.
|
|
|
|
|
if (num_inspected_literals_ <= 1e9) ProcessLiteral(l);
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Release some memory.
|
|
|
|
|
literal_to_clauses_.clear();
|
|
|
|
|
|
|
|
|
|
dtime_ += 1e-8 * num_inspected_literals_;
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime_);
|
|
|
|
|
log_info |= VLOG_IS_ON(1);
|
2020-10-22 23:36:58 +02:00
|
|
|
LOG_IF(INFO, log_info) << "Blocked clause. num_blocked_clauses: "
|
|
|
|
|
<< num_blocked_clauses_ << " dtime: " << dtime_
|
|
|
|
|
<< " wtime: " << wall_timer.Get();
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void BlockedClauseSimplifier::InitializeForNewRound() {
|
|
|
|
|
clauses_.clear();
|
|
|
|
|
clause_manager_->DeleteRemovedClauses();
|
|
|
|
|
clause_manager_->DetachAllClauses();
|
2020-10-28 13:42:36 +01:00
|
|
|
for (SatClause* c : clause_manager_->AllClausesInCreationOrder()) {
|
2020-06-03 12:07:07 +02:00
|
|
|
// We ignore redundant clause. This shouldn't cause any validity issue.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clause_manager_->IsRemovable(c)) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
clauses_.push_back(c);
|
|
|
|
|
}
|
|
|
|
|
const int num_literals = clause_manager_->literal_size();
|
|
|
|
|
|
|
|
|
|
// TODO(user): process in order of increasing number of clause that contains
|
|
|
|
|
// not(l)?
|
|
|
|
|
in_queue_.assign(num_literals, true);
|
|
|
|
|
for (LiteralIndex l(0); l < num_literals; ++l) {
|
|
|
|
|
queue_.push_back(Literal(l));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
marked_.resize(num_literals);
|
2020-10-22 23:36:58 +02:00
|
|
|
DCHECK(
|
|
|
|
|
std::all_of(marked_.begin(), marked_.end(), [](bool b) { return !b; }));
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// TODO(user): because we don't create new clause here we can use a flat
|
|
|
|
|
// vector for literal_to_clauses_.
|
|
|
|
|
literal_to_clauses_.clear();
|
|
|
|
|
literal_to_clauses_.resize(num_literals);
|
|
|
|
|
for (ClauseIndex i(0); i < clauses_.size(); ++i) {
|
|
|
|
|
for (const Literal l : clauses_[i]->AsSpan()) {
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_clauses_[l].push_back(i);
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
num_inspected_literals_ += clauses_[i]->size();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void BlockedClauseSimplifier::ProcessLiteral(Literal current_literal) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.LiteralIsAssigned(current_literal)) return;
|
|
|
|
|
if (implication_graph_->IsRemoved(current_literal)) return;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// We want to check first that this clause will resolve to trivial clause with
|
|
|
|
|
// all binary containing not(current_literal). So mark all literal l so that
|
|
|
|
|
// current_literal => l.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): We do not need to redo that each time we reprocess
|
|
|
|
|
// current_literal.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Ignore redundant literals. That might require pushing
|
|
|
|
|
// equivalence to the postsolve stack though. Better to simply remove
|
|
|
|
|
// these equivalence if we are allowed to and update the postsolve then.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Make this work in the presence of at most ones.
|
|
|
|
|
int num_binary = 0;
|
2020-10-28 13:42:36 +01:00
|
|
|
const std::vector<Literal>& implications =
|
2020-06-03 12:07:07 +02:00
|
|
|
implication_graph_->DirectImplications(current_literal);
|
|
|
|
|
for (const Literal l : implications) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (l == current_literal) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
++num_binary;
|
2023-10-12 10:06:27 +02:00
|
|
|
marked_[l] = true;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): We could also mark a small clause containing
|
|
|
|
|
// current_literal.Negated(), and make sure we only include in
|
|
|
|
|
// clauses_to_process clauses that resolve trivially with that clause.
|
|
|
|
|
std::vector<ClauseIndex> clauses_to_process;
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const ClauseIndex i : literal_to_clauses_[current_literal]) {
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clauses_[i]->IsRemoved()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Blocked with respect to binary clause only? all marked binary should have
|
|
|
|
|
// their negation in clause.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Abort if size left is too small.
|
|
|
|
|
if (num_binary > 0) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clauses_[i]->size() <= num_binary) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
int num_with_negation_marked = 0;
|
|
|
|
|
for (const Literal l : clauses_[i]->AsSpan()) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (l == current_literal) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (marked_[l.NegatedIndex()]) {
|
|
|
|
|
++num_with_negation_marked;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
num_inspected_literals_ += clauses_[i]->size();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (num_with_negation_marked < num_binary) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
clauses_to_process.push_back(i);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Clear marked.
|
|
|
|
|
for (const Literal l : implications) {
|
2023-10-12 10:06:27 +02:00
|
|
|
marked_[l] = false;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): There is a possible optimization: If we mark all literals of
|
|
|
|
|
// all the clause to process, we can check that each clause containing
|
|
|
|
|
// current_literal.Negated() contains at least one of these literal negated
|
|
|
|
|
// other than current_literal. Otherwise none of the clause are blocked.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): If a clause cannot be blocked because of another clause, then
|
|
|
|
|
// when we call ProcessLiteral(current_literal.Negated()) we can skip some
|
|
|
|
|
// inspection.
|
|
|
|
|
for (const ClauseIndex i : clauses_to_process) {
|
|
|
|
|
const auto c = clauses_[i]->AsSpan();
|
|
|
|
|
if (ClauseIsBlocked(current_literal, c)) {
|
|
|
|
|
// Reprocess all clauses that have a negated literal in this one as
|
|
|
|
|
// some might be blocked now.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Maybe we can remember for which (literal, clause) pair this
|
|
|
|
|
// was used as a certificate for "not-blocked" and just reprocess those,
|
|
|
|
|
// but it might be memory intensive.
|
|
|
|
|
for (const Literal l : c) {
|
|
|
|
|
if (!in_queue_[l.NegatedIndex()]) {
|
|
|
|
|
in_queue_[l.NegatedIndex()] = true;
|
|
|
|
|
queue_.push_back(l.Negated());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Add the clause to the postsolving set.
|
|
|
|
|
postsolve_->AddClauseWithSpecialLiteral(current_literal, c);
|
|
|
|
|
|
|
|
|
|
// We can remove a blocked clause.
|
|
|
|
|
++num_blocked_clauses_;
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clauses_[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Note that this assume that the binary clauses have already been checked.
|
2020-10-22 23:36:58 +02:00
|
|
|
bool BlockedClauseSimplifier::ClauseIsBlocked(
|
|
|
|
|
Literal current_literal, absl::Span<const Literal> clause) {
|
2020-06-03 12:07:07 +02:00
|
|
|
bool is_blocked = true;
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const Literal l : clause) marked_[l] = true;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// TODO(user): For faster reprocessing of the same literal, we should move
|
|
|
|
|
// all clauses that are used in a non-blocked certificate first in the list.
|
|
|
|
|
for (const ClauseIndex i :
|
|
|
|
|
literal_to_clauses_[current_literal.NegatedIndex()]) {
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clauses_[i]->IsRemoved()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
bool some_marked = false;
|
|
|
|
|
for (const Literal l : clauses_[i]->AsSpan()) {
|
|
|
|
|
// TODO(user): we can be faster here by only updating it at the end?
|
|
|
|
|
++num_inspected_literals_;
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (l == current_literal.Negated()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (marked_[l.NegatedIndex()]) {
|
|
|
|
|
some_marked = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (!some_marked) {
|
|
|
|
|
is_blocked = false;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const Literal l : clause) marked_[l] = false;
|
2020-06-03 12:07:07 +02:00
|
|
|
return is_blocked;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool BoundedVariableElimination::DoOneRound(bool log_info) {
|
|
|
|
|
WallTimer wall_timer;
|
|
|
|
|
wall_timer.Start();
|
|
|
|
|
|
|
|
|
|
dtime_ = 0.0;
|
|
|
|
|
num_inspected_literals_ = 0;
|
|
|
|
|
num_eliminated_variables_ = 0;
|
|
|
|
|
num_literals_diff_ = 0;
|
|
|
|
|
num_clauses_diff_ = 0;
|
|
|
|
|
num_simplifications_ = 0;
|
|
|
|
|
num_blocked_clauses_ = 0;
|
|
|
|
|
|
|
|
|
|
clauses_.clear();
|
|
|
|
|
clause_manager_->DeleteRemovedClauses();
|
|
|
|
|
clause_manager_->DetachAllClauses();
|
2020-10-28 13:42:36 +01:00
|
|
|
for (SatClause* c : clause_manager_->AllClausesInCreationOrder()) {
|
2020-06-03 12:07:07 +02:00
|
|
|
// We ignore redundant clause. This shouldn't cause any validity issue.
|
|
|
|
|
// TODO(user): but we shouldn't keep clauses containing removed literals.
|
|
|
|
|
// It is still valid to do so, but it should be less efficient.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clause_manager_->IsRemovable(c)) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
clauses_.push_back(c);
|
|
|
|
|
}
|
|
|
|
|
const int num_literals = clause_manager_->literal_size();
|
|
|
|
|
const int num_variables = num_literals / 2;
|
|
|
|
|
|
|
|
|
|
literal_to_clauses_.clear();
|
|
|
|
|
literal_to_clauses_.resize(num_literals);
|
|
|
|
|
literal_to_num_clauses_.assign(num_literals, 0);
|
|
|
|
|
for (ClauseIndex i(0); i < clauses_.size(); ++i) {
|
|
|
|
|
for (const Literal l : clauses_[i]->AsSpan()) {
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_clauses_[l].push_back(i);
|
|
|
|
|
literal_to_num_clauses_[l]++;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
num_inspected_literals_ += clauses_[i]->size();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const int saved_trail_index = trail_->Index();
|
|
|
|
|
propagation_index_ = trail_->Index();
|
|
|
|
|
|
|
|
|
|
need_to_be_updated_.clear();
|
|
|
|
|
in_need_to_be_updated_.resize(num_variables);
|
2025-01-19 12:04:23 +01:00
|
|
|
DCHECK(absl::c_find(in_need_to_be_updated_, true) ==
|
|
|
|
|
in_need_to_be_updated_.end());
|
2020-06-03 12:07:07 +02:00
|
|
|
queue_.Reserve(num_variables);
|
|
|
|
|
for (BooleanVariable v(0); v < num_variables; ++v) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.VariableIsAssigned(v)) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
UpdatePriorityQueue(v);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
marked_.resize(num_literals);
|
2020-10-22 23:36:58 +02:00
|
|
|
DCHECK(
|
|
|
|
|
std::all_of(marked_.begin(), marked_.end(), [](bool b) { return !b; }));
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// TODO(user): add a local dtime limit for the corner case where this take too
|
|
|
|
|
// much time. We can adapt the limit depending on how much we want to spend on
|
|
|
|
|
// inprocessing.
|
|
|
|
|
while (!time_limit_->LimitReached() && !queue_.IsEmpty()) {
|
|
|
|
|
const BooleanVariable top = queue_.Top().var;
|
|
|
|
|
queue_.Pop();
|
|
|
|
|
|
|
|
|
|
// Make sure we fix variables first if needed. Note that because new binary
|
|
|
|
|
// clause might appear when we fix variables, we need a loop here.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): we might also find new equivalent variable l => var => l
|
|
|
|
|
// here, but for now we ignore those.
|
|
|
|
|
bool is_unsat = false;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!Propagate()) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
while (implication_graph_->FindFailedLiteralAroundVar(top, &is_unsat)) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!Propagate()) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (is_unsat) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!CrossProduct(top)) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
for (const BooleanVariable v : need_to_be_updated_) {
|
|
|
|
|
in_need_to_be_updated_[v] = false;
|
|
|
|
|
|
|
|
|
|
// Currently we never re-add top if we just processed it.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (v != top) UpdatePriorityQueue(v);
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
need_to_be_updated_.clear();
|
|
|
|
|
}
|
|
|
|
|
|
2023-12-04 15:06:08 +01:00
|
|
|
if (!Propagate()) return false;
|
|
|
|
|
implication_graph_->CleanupAllRemovedAndFixedVariables();
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Remove all redundant clause containing a removed literal. This avoid to
|
|
|
|
|
// re-introduce a removed literal via conflict learning.
|
2020-10-28 13:42:36 +01:00
|
|
|
for (SatClause* c : clause_manager_->AllClausesInCreationOrder()) {
|
2020-06-03 12:07:07 +02:00
|
|
|
bool remove = false;
|
|
|
|
|
for (const Literal l : c->AsSpan()) {
|
|
|
|
|
if (implication_graph_->IsRemoved(l)) {
|
|
|
|
|
remove = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (remove) clause_manager_->InprocessingRemoveClause(c);
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Release some memory.
|
|
|
|
|
literal_to_clauses_.clear();
|
|
|
|
|
literal_to_num_clauses_.clear();
|
|
|
|
|
|
|
|
|
|
dtime_ += 1e-8 * num_inspected_literals_;
|
|
|
|
|
time_limit_->AdvanceDeterministicTime(dtime_);
|
|
|
|
|
log_info |= VLOG_IS_ON(1);
|
2024-10-07 11:08:38 +02:00
|
|
|
LOG_IF(INFO, log_info) << "BVE."
|
|
|
|
|
<< " num_fixed: "
|
2020-10-22 23:36:58 +02:00
|
|
|
<< trail_->Index() - saved_trail_index
|
|
|
|
|
<< " num_simplified_literals: " << num_simplifications_
|
|
|
|
|
<< " num_blocked_clauses_: " << num_blocked_clauses_
|
|
|
|
|
<< " num_eliminations: " << num_eliminated_variables_
|
|
|
|
|
<< " num_literals_diff: " << num_literals_diff_
|
|
|
|
|
<< " num_clause_diff: " << num_clauses_diff_
|
|
|
|
|
<< " dtime: " << dtime_
|
|
|
|
|
<< " wtime: " << wall_timer.Get();
|
2020-06-03 12:07:07 +02:00
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
bool BoundedVariableElimination::RemoveLiteralFromClause(
|
2020-10-28 13:42:36 +01:00
|
|
|
Literal lit, SatClause* sat_clause) {
|
2020-06-03 12:07:07 +02:00
|
|
|
num_literals_diff_ -= sat_clause->size();
|
|
|
|
|
resolvant_.clear();
|
|
|
|
|
for (const Literal l : sat_clause->AsSpan()) {
|
|
|
|
|
if (l == lit || assignment_.LiteralIsFalse(l)) {
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_num_clauses_[l]--;
|
2020-06-03 12:07:07 +02:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if (assignment_.LiteralIsTrue(l)) {
|
|
|
|
|
num_clauses_diff_--;
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(sat_clause);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
resolvant_.push_back(l);
|
|
|
|
|
}
|
|
|
|
|
if (!clause_manager_->InprocessingRewriteClause(sat_clause, resolvant_)) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2023-12-04 15:06:08 +01:00
|
|
|
if (sat_clause->IsRemoved()) {
|
2020-06-03 12:07:07 +02:00
|
|
|
--num_clauses_diff_;
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const Literal l : resolvant_) literal_to_num_clauses_[l]--;
|
2020-06-03 12:07:07 +02:00
|
|
|
} else {
|
|
|
|
|
num_literals_diff_ += sat_clause->size();
|
|
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool BoundedVariableElimination::Propagate() {
|
|
|
|
|
for (; propagation_index_ < trail_->Index(); ++propagation_index_) {
|
|
|
|
|
// Make sure we always propagate the binary clauses first.
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!implication_graph_->Propagate(trail_)) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
const Literal l = (*trail_)[propagation_index_];
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const ClauseIndex index : literal_to_clauses_[l]) {
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clauses_[index]->IsRemoved()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
num_clauses_diff_--;
|
|
|
|
|
num_literals_diff_ -= clauses_[index]->size();
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(clauses_[index]);
|
|
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_clauses_[l].clear();
|
2020-06-03 12:07:07 +02:00
|
|
|
for (const ClauseIndex index : literal_to_clauses_[l.NegatedIndex()]) {
|
2023-12-04 15:06:08 +01:00
|
|
|
if (clauses_[index]->IsRemoved()) continue;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!RemoveLiteralFromClause(l.Negated(), clauses_[index])) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
literal_to_clauses_[l.NegatedIndex()].clear();
|
|
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Note that we use the estimated size here to make it fast. It is okay if the
|
|
|
|
|
// order of elimination is not perfect... We can improve on this later.
|
|
|
|
|
int BoundedVariableElimination::NumClausesContaining(Literal l) {
|
2023-10-12 10:06:27 +02:00
|
|
|
return literal_to_num_clauses_[l] +
|
2020-06-03 12:07:07 +02:00
|
|
|
implication_graph_->DirectImplicationsEstimatedSize(l.Negated());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): Only enqueue variable that can be removed.
|
|
|
|
|
void BoundedVariableElimination::UpdatePriorityQueue(BooleanVariable var) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.VariableIsAssigned(var)) return;
|
2023-12-04 15:06:08 +01:00
|
|
|
if (implication_graph_->IsRemoved(Literal(var, true))) return;
|
|
|
|
|
if (implication_graph_->IsRedundant(Literal(var, true))) return;
|
2020-06-03 12:07:07 +02:00
|
|
|
const int priority = -NumClausesContaining(Literal(var, true)) -
|
|
|
|
|
NumClausesContaining(Literal(var, false));
|
|
|
|
|
if (queue_.Contains(var.value())) {
|
2020-10-22 23:36:58 +02:00
|
|
|
queue_.ChangePriority({var, priority});
|
2020-06-03 12:07:07 +02:00
|
|
|
} else {
|
2020-10-22 23:36:58 +02:00
|
|
|
queue_.Add({var, priority});
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-28 13:42:36 +01:00
|
|
|
void BoundedVariableElimination::DeleteClause(SatClause* sat_clause) {
|
2020-06-03 12:07:07 +02:00
|
|
|
const auto clause = sat_clause->AsSpan();
|
|
|
|
|
|
|
|
|
|
num_clauses_diff_--;
|
|
|
|
|
num_literals_diff_ -= clause.size();
|
|
|
|
|
|
|
|
|
|
// Update literal <-> clause graph.
|
|
|
|
|
for (const Literal l : clause) {
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_num_clauses_[l]--;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!in_need_to_be_updated_[l.Variable()]) {
|
|
|
|
|
in_need_to_be_updated_[l.Variable()] = true;
|
|
|
|
|
need_to_be_updated_.push_back(l.Variable());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Lazy deletion of the clause.
|
|
|
|
|
clause_manager_->InprocessingRemoveClause(sat_clause);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void BoundedVariableElimination::DeleteAllClausesContaining(Literal literal) {
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const ClauseIndex i : literal_to_clauses_[literal]) {
|
2020-06-03 12:07:07 +02:00
|
|
|
const auto clause = clauses_[i]->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clause.empty()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
postsolve_->AddClauseWithSpecialLiteral(literal, clause);
|
|
|
|
|
DeleteClause(clauses_[i]);
|
|
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_clauses_[literal].clear();
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void BoundedVariableElimination::AddClause(absl::Span<const Literal> clause) {
|
2020-10-28 13:42:36 +01:00
|
|
|
SatClause* pt = clause_manager_->InprocessingAddClause(clause);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (pt == nullptr) return;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
num_clauses_diff_++;
|
|
|
|
|
num_literals_diff_ += clause.size();
|
|
|
|
|
|
|
|
|
|
const ClauseIndex index(clauses_.size());
|
|
|
|
|
clauses_.push_back(pt);
|
|
|
|
|
for (const Literal l : clause) {
|
2023-10-12 10:06:27 +02:00
|
|
|
literal_to_num_clauses_[l]++;
|
|
|
|
|
literal_to_clauses_[l].push_back(index);
|
2020-06-03 12:07:07 +02:00
|
|
|
if (!in_need_to_be_updated_[l.Variable()]) {
|
|
|
|
|
in_need_to_be_updated_[l.Variable()] = true;
|
|
|
|
|
need_to_be_updated_.push_back(l.Variable());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
template <bool score_only, bool with_binary_only>
|
|
|
|
|
bool BoundedVariableElimination::ResolveAllClauseContaining(Literal lit) {
|
|
|
|
|
const int clause_weight = parameters_.presolve_bve_clause_weight();
|
|
|
|
|
|
2020-10-28 13:42:36 +01:00
|
|
|
const std::vector<Literal>& implications =
|
2020-06-03 12:07:07 +02:00
|
|
|
implication_graph_->DirectImplications(lit);
|
2023-10-12 10:06:27 +02:00
|
|
|
auto& clause_containing_lit = literal_to_clauses_[lit];
|
2020-06-03 12:07:07 +02:00
|
|
|
for (int i = 0; i < clause_containing_lit.size(); ++i) {
|
|
|
|
|
const ClauseIndex clause_index = clause_containing_lit[i];
|
|
|
|
|
const auto clause = clauses_[clause_index]->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (clause.empty()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!score_only) resolvant_.clear();
|
2020-06-03 12:07:07 +02:00
|
|
|
for (const Literal l : clause) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!score_only && l != lit) resolvant_.push_back(l);
|
2023-10-12 10:06:27 +02:00
|
|
|
marked_[l] = true;
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
DCHECK(marked_[lit]);
|
2020-06-03 12:07:07 +02:00
|
|
|
num_inspected_literals_ += clause.size() + implications.size();
|
|
|
|
|
|
|
|
|
|
// If this is true, then "clause" is subsumed by one of its resolvant and we
|
|
|
|
|
// can just remove lit from it. Then it doesn't need to be acounted at all.
|
|
|
|
|
bool clause_can_be_simplified = false;
|
2021-03-04 18:26:01 +01:00
|
|
|
const int64_t saved_score = new_score_;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Resolution with binary clauses.
|
|
|
|
|
for (const Literal l : implications) {
|
|
|
|
|
CHECK_NE(l, lit);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (marked_[l.NegatedIndex()]) continue; // trivial.
|
2023-10-12 10:06:27 +02:00
|
|
|
if (marked_[l]) {
|
2020-06-03 12:07:07 +02:00
|
|
|
clause_can_be_simplified = true;
|
|
|
|
|
break;
|
|
|
|
|
} else {
|
|
|
|
|
if (score_only) {
|
|
|
|
|
new_score_ += clause_weight + clause.size();
|
|
|
|
|
} else {
|
|
|
|
|
resolvant_.push_back(l);
|
|
|
|
|
AddClause(resolvant_);
|
|
|
|
|
resolvant_.pop_back();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Resolution with non-binary clauses.
|
|
|
|
|
if (!with_binary_only && !clause_can_be_simplified) {
|
2020-10-28 13:42:36 +01:00
|
|
|
auto& clause_containing_not_lit = literal_to_clauses_[lit.NegatedIndex()];
|
2020-06-03 12:07:07 +02:00
|
|
|
for (int j = 0; j < clause_containing_not_lit.size(); ++j) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (score_only && new_score_ > score_threshold_) break;
|
2020-06-03 12:07:07 +02:00
|
|
|
const ClauseIndex other_index = clause_containing_not_lit[j];
|
|
|
|
|
const auto other = clauses_[other_index]->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (other.empty()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
bool trivial = false;
|
|
|
|
|
int extra_size = 0;
|
|
|
|
|
for (const Literal l : other) {
|
|
|
|
|
// TODO(user): we can optimize this by updating it outside the loop.
|
|
|
|
|
++num_inspected_literals_;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (l == lit.Negated()) continue;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (marked_[l.NegatedIndex()]) {
|
|
|
|
|
trivial = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
if (!marked_[l]) {
|
2020-06-03 12:07:07 +02:00
|
|
|
++extra_size;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!score_only) resolvant_.push_back(l);
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (trivial) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!score_only) resolvant_.resize(resolvant_.size() - extra_size);
|
2020-06-03 12:07:07 +02:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// If this is the case, the other clause is subsumed by the resolvant.
|
|
|
|
|
// We can just remove not_lit from it and ignore it.
|
|
|
|
|
if (score_only && clause.size() + extra_size <= other.size()) {
|
2022-02-23 17:10:23 +01:00
|
|
|
// TODO(user): We should have an exact equality here, except if
|
|
|
|
|
// presolve is off before the clause are added to the sat solver and
|
|
|
|
|
// we have duplicate literals. The code should still work but it
|
|
|
|
|
// wasn't written with that in mind nor tested like this, so we should
|
|
|
|
|
// just enforce the invariant.
|
|
|
|
|
if (false) DCHECK_EQ(clause.size() + extra_size, other.size());
|
2020-06-03 12:07:07 +02:00
|
|
|
++num_simplifications_;
|
|
|
|
|
|
|
|
|
|
// Note that we update the threshold since this clause was counted in
|
|
|
|
|
// it.
|
|
|
|
|
score_threshold_ -= clause_weight + other.size();
|
|
|
|
|
|
|
|
|
|
if (extra_size == 0) {
|
|
|
|
|
// We have a double self-subsumption. We can just remove this
|
|
|
|
|
// clause since it will be subsumed by the clause created in the
|
|
|
|
|
// "clause_can_be_simplified" case below.
|
|
|
|
|
DeleteClause(clauses_[other_index]);
|
|
|
|
|
} else {
|
|
|
|
|
if (!RemoveLiteralFromClause(lit.Negated(),
|
|
|
|
|
clauses_[other_index])) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
std::swap(clause_containing_not_lit[j],
|
|
|
|
|
clause_containing_not_lit.back());
|
|
|
|
|
clause_containing_not_lit.pop_back();
|
2020-10-22 23:36:58 +02:00
|
|
|
--j; // Reprocess the new position.
|
2020-06-03 12:07:07 +02:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (extra_size == 0) {
|
|
|
|
|
clause_can_be_simplified = true;
|
|
|
|
|
break;
|
|
|
|
|
} else {
|
|
|
|
|
if (score_only) {
|
|
|
|
|
// Hack. We do not want to create long clauses during BVE.
|
|
|
|
|
if (clause.size() - 1 + extra_size > 100) {
|
|
|
|
|
new_score_ = score_threshold_ + 1;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
new_score_ += clause_weight + clause.size() - 1 + extra_size;
|
|
|
|
|
} else {
|
|
|
|
|
AddClause(resolvant_);
|
|
|
|
|
resolvant_.resize(resolvant_.size() - extra_size);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Note that we need to clear marked before aborting.
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const Literal l : clause) marked_[l] = false;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// In this case, we simplify and remove the clause from here.
|
|
|
|
|
if (clause_can_be_simplified) {
|
|
|
|
|
++num_simplifications_;
|
|
|
|
|
|
|
|
|
|
// Note that we update the threshold as if this was simplified before.
|
|
|
|
|
new_score_ = saved_score;
|
|
|
|
|
score_threshold_ -= clause_weight + clause.size();
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!RemoveLiteralFromClause(lit, clauses_[clause_index])) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
std::swap(clause_containing_lit[i], clause_containing_lit.back());
|
|
|
|
|
clause_containing_lit.pop_back();
|
2020-10-22 23:36:58 +02:00
|
|
|
--i; // Reprocess the new position.
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
if (score_only && new_score_ > score_threshold_) return true;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// When this happen, then the clause is blocked (i.e. all its resolvant are
|
|
|
|
|
// trivial). So even if we do not actually perform the variable elimination,
|
|
|
|
|
// we can still remove this clause. Note that we treat the score as if the
|
|
|
|
|
// clause was removed before.
|
|
|
|
|
//
|
|
|
|
|
// Tricky: The detection only work if we didn't abort the computation above,
|
|
|
|
|
// so we do that after the score_threshold_ check.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Also detect blocked clause for not(lit)? It is not as cheap
|
|
|
|
|
// though and require more code.
|
|
|
|
|
if (score_only && !with_binary_only && !clause_can_be_simplified &&
|
|
|
|
|
new_score_ == saved_score) {
|
|
|
|
|
++num_blocked_clauses_;
|
|
|
|
|
score_threshold_ -= clause_weight + clause.size();
|
|
|
|
|
postsolve_->AddClauseWithSpecialLiteral(lit, clause);
|
|
|
|
|
DeleteClause(clauses_[clause_index]);
|
|
|
|
|
}
|
2020-05-13 11:30:15 +02:00
|
|
|
}
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2020-06-03 12:07:07 +02:00
|
|
|
bool BoundedVariableElimination::CrossProduct(BooleanVariable var) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (assignment_.VariableIsAssigned(var)) return true;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
const Literal lit(var, true);
|
|
|
|
|
const Literal not_lit(var, false);
|
2023-12-04 15:06:08 +01:00
|
|
|
DCHECK(!implication_graph_->IsRedundant(lit));
|
2020-06-03 12:07:07 +02:00
|
|
|
{
|
|
|
|
|
const int s1 = NumClausesContaining(lit);
|
|
|
|
|
const int s2 = NumClausesContaining(not_lit);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (s1 == 0 && s2 == 0) return true;
|
2020-06-03 12:07:07 +02:00
|
|
|
if (s1 > 0 && s2 == 0) {
|
|
|
|
|
num_eliminated_variables_++;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(lit)) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
DeleteAllClausesContaining(lit);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
if (s1 == 0 && s2 > 0) {
|
|
|
|
|
num_eliminated_variables_++;
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!clause_manager_->InprocessingFixLiteral(not_lit)) return false;
|
2020-06-03 12:07:07 +02:00
|
|
|
DeleteAllClausesContaining(not_lit);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Heuristic. Abort if the work required to decide if var should be removed
|
|
|
|
|
// seems to big.
|
|
|
|
|
if (s1 > 1 && s2 > 1 && s1 * s2 > parameters_.presolve_bve_threshold()) {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// TODO(user): swap lit and not_lit for speed? it is unclear if we prefer
|
|
|
|
|
// to minimize the number of clause containing lit or not_lit though. Also,
|
|
|
|
|
// we might want to alternate since we also detect blocked clause containing
|
|
|
|
|
// lit, but don't do it for not_lit.
|
|
|
|
|
|
|
|
|
|
// Compute the current score.
|
|
|
|
|
// TODO(user): cleanup the list lazily at the same time?
|
2021-03-04 18:26:01 +01:00
|
|
|
int64_t score = 0;
|
2020-06-03 12:07:07 +02:00
|
|
|
const int clause_weight = parameters_.presolve_bve_clause_weight();
|
|
|
|
|
score +=
|
|
|
|
|
implication_graph_->DirectImplications(lit).size() * (clause_weight + 2);
|
|
|
|
|
score += implication_graph_->DirectImplications(not_lit).size() *
|
|
|
|
|
(clause_weight + 2);
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const ClauseIndex i : literal_to_clauses_[lit]) {
|
2020-06-03 12:07:07 +02:00
|
|
|
const auto c = clauses_[i]->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!c.empty()) score += clause_weight + c.size();
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
2023-10-12 10:06:27 +02:00
|
|
|
for (const ClauseIndex i : literal_to_clauses_[not_lit]) {
|
2020-06-03 12:07:07 +02:00
|
|
|
const auto c = clauses_[i]->AsSpan();
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!c.empty()) score += clause_weight + c.size();
|
2020-06-03 12:07:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Compute the new score after BVE.
|
|
|
|
|
// Abort as soon as it crosses the threshold.
|
|
|
|
|
//
|
|
|
|
|
// TODO(user): Experiment with leaving the implications graph as is. This will
|
|
|
|
|
// not remove the variable completely, but it seems interesting since after
|
|
|
|
|
// equivalent variable removal and failed literal probing, the cross product
|
|
|
|
|
// of the implication always add a quadratic number of implication, except if
|
|
|
|
|
// the in (or out) degree is zero or one.
|
|
|
|
|
score_threshold_ = score;
|
|
|
|
|
new_score_ = implication_graph_->NumImplicationOnVariableRemoval(var) *
|
|
|
|
|
(clause_weight + 2);
|
2020-10-22 23:36:58 +02:00
|
|
|
if (new_score_ > score_threshold_) return true;
|
|
|
|
|
if (!ResolveAllClauseContaining</*score_only=*/true,
|
|
|
|
|
/*with_binary_only=*/true>(not_lit)) {
|
2020-06-03 12:07:07 +02:00
|
|
|
return false;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (new_score_ > score_threshold_) return true;
|
|
|
|
|
if (!ResolveAllClauseContaining</*score_only=*/true,
|
|
|
|
|
/*with_binary_only=*/false>(lit)) {
|
2020-06-03 12:07:07 +02:00
|
|
|
return false;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (new_score_ > score_threshold_) return true;
|
2020-06-03 12:07:07 +02:00
|
|
|
|
|
|
|
|
// Perform BVE.
|
|
|
|
|
if (new_score_ > 0) {
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!ResolveAllClauseContaining</*score_only=*/false,
|
|
|
|
|
/*with_binary_only=*/false>(lit)) {
|
2020-06-03 12:07:07 +02:00
|
|
|
return false;
|
|
|
|
|
}
|
2020-10-22 23:36:58 +02:00
|
|
|
if (!ResolveAllClauseContaining</*score_only=*/false,
|
|
|
|
|
/*with_binary_only=*/true>(not_lit)) {
|
2020-06-03 12:07:07 +02:00
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
++num_eliminated_variables_;
|
|
|
|
|
implication_graph_->RemoveBooleanVariable(var, &postsolve_->clauses);
|
|
|
|
|
DeleteAllClausesContaining(lit);
|
|
|
|
|
DeleteAllClausesContaining(not_lit);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2020-10-22 23:36:58 +02:00
|
|
|
} // namespace sat
|
|
|
|
|
} // namespace operations_research
|