From 128b0a13faccf809f3bfd3be37281502a3297d41 Mon Sep 17 00:00:00 2001 From: Arnab Animesh Das Date: Fri, 21 Feb 2025 16:30:48 +0530 Subject: [PATCH] Remove comment regarding only static builds being supported on Windows (#4559) * Remove comment regarding only static builds being supported on Windows * Minor fix --- CMakeLists.txt | 1 - ortools/cpp/CMakeLists.txt.in | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 9ba9748d80..91917769c1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -73,7 +73,6 @@ if(UNIX) set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_BINARY_DIR}/${OutputConfig}/${CMAKE_INSTALL_BINDIR}) endforeach() else() - # Currently Only support static build for windows option(BUILD_SHARED_LIBS "Build shared libraries (.dll)." ON) set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR}) set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR}) diff --git a/ortools/cpp/CMakeLists.txt.in b/ortools/cpp/CMakeLists.txt.in index caf95d80db..d96b8e24f8 100644 --- a/ortools/cpp/CMakeLists.txt.in +++ b/ortools/cpp/CMakeLists.txt.in @@ -52,8 +52,7 @@ if(UNIX) set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_${OUTPUTCONFIG} ${CMAKE_BINARY_DIR}/${OutputConfig}/${CMAKE_INSTALL_BINDIR}) endforeach() else() - # Currently Only support static build for windows - option(BUILD_SHARED_LIBS "Build shared libraries (.dll)." OFF) + option(BUILD_SHARED_LIBS "Build shared libraries (.dll)." ON) set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR}) set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR}) set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_BINDIR})