From 6c5b1555281d7b3654eb084d98cb20650bb3ebca Mon Sep 17 00:00:00 2001
From: Laurent Perron <lperron@google.com>
Date: Wed, 5 Jul 2017 06:25:55 -0700
Subject: [PATCH] better code in AlphaNum

---
 ortools/base/join.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ortools/base/join.h b/ortools/base/join.h
index cb283a9e9d..834255bcf0 100644
--- a/ortools/base/join.h
+++ b/ortools/base/join.h
@@ -25,14 +25,14 @@
 const int kFastToBufferSize = 32;
 
 // Writes output to the beginning of the given buffer. Returns a pointer to the
-// end of the std::string (i.e. to the NUL char). Buffer must be at least 12 bytes.
-// Not actually fast, but maybe someday!
+// end of the std::string (i.e. to the NUL char). Buffer must be at least 12
+// bytes. Not actually fast, but maybe someday!
 template <class T>
 char* NumToBuffer(T i, char* buffer) {
   std::stringstream ss;
   ss << i;
   const std::string s = ss.str();
-  strncpy(buffer, s.c_str(), s.size());  // NOLINT
+  strncpy(buffer, s.c_str(), kFastToBufferSize);  // NOLINT
   return buffer + s.size();
 }
 
@@ -58,13 +58,13 @@ struct AlphaNum {
   AlphaNum(float f)  // NOLINT(runtime/explicit)
       : piece(digits, strlen(NumToBuffer(f, digits))) {}
   AlphaNum(double f)  {  // NOLINT(runtime/explicit)
-    sprintf(digits, "%lf\n", f);
+    snprintf(digits, kFastToBufferSize, "%lf", f);
     piece.set(digits);
   }
   AlphaNum(const char* c_str) : piece(c_str) {}   // NOLINT(runtime/explicit)
   AlphaNum(const operations_research::string_view& pc)
       : piece(pc) {}                              // NOLINT(runtime/explicit)
-  AlphaNum(const std::string& s) : piece(s) {}         // NOLINT(runtime/explicit)
+  AlphaNum(const std::string& s) : piece(s) {}    // NOLINT(runtime/explicit)
 
   operations_research::string_view::size_type size() const {
     return piece.size();